docs: fix skipTrailingSlashRedirect middleware example #65220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Next.js team
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ztanner
requested review from
manovotny and
delbaoliveira
and removed request for
a team
ijjk
approved these changes
Apr 30, 2024
ztanner
deleted the
04-30-docs_fix_skipTrailingSlashRedirect_middleware_example
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example here only updates the pathname, but the redirect path is determined by taking the
req.nextUrlobject and stringifying it, which means it would return the wrong redirect location.Closes NEXT-3260